Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can kiwix-tools armv6 and armv8 be made downloadable with version-independent redirects, as with all other arch's? #623

Closed
holta opened this issue Jun 2, 2023 · 21 comments
Assignees
Labels
Milestone

Comments

@kelson42 kelson42 self-assigned this Jun 2, 2023
@kelson42 kelson42 added this to the 3.5.0 milestone Jun 2, 2023
@kelson42
Copy link
Contributor

kelson42 commented Jun 2, 2023

@holta Working redirects are listed on Product page. AFAIK all the binaries are available through them, so we don't need anything additional.

@mgautierfr Why do we have newly files kiwix-tools_linux-armv8-3.5.0-1.tar.gz and kiwix-tools_linux-armv6-3.5.0-1.tar.gz. We should stick to the aarch64 and armhf like before, otherwise it should have been discussed. Why we don't have the latest build of kiwix-tools_linux-armhf-3.5.0.tar.gz? It's important we stick to the naming, otherwise it has important consequences.

@kelson42 kelson42 assigned mgautierfr and unassigned kelson42 Jun 2, 2023
@kelson42 kelson42 added bug and removed question labels Jun 2, 2023
@mgautierfr
Copy link
Member

@mgautierfr Why do we have newly files kiwix-tools_linux-armv8-3.5.0-1.tar.gz and kiwix-tools_linux-armv6-3.5.0-1.tar.gz. We should stick to the aarch64 and armhf like before, otherwise it should have been discussed. Why we don't have the latest build of kiwix-tools_linux-armhf-3.5.0.tar.gz? It's important we stick to the naming, otherwise it has important consequences.

This came from this PR : kiwix/kiwix-build#615

As said in the description: "This introduce a difference between armv6 and armv8."

@kelson42
Copy link
Contributor

kelson42 commented Jun 7, 2023

@rgaudin Any feedback about the differences and benefits between armhf, armv6, armv7 and armv8?

@rgaudin
Copy link
Member

rgaudin commented Jun 8, 2023

@rgaudin
Copy link
Member

rgaudin commented Jun 8, 2023

Let me know if should add the redirects ; for Linux we currently build

  • kiwix-tools_linux-x86_64
  • kiwix-tools_linux-aarch64
  • kiwix-tools_linux-armv6
  • kiwix-tools_linux-armv8
  • kiwix-tools_linux-i586

Here's the Dockerfile for kiwix-tools image (not merged)

if [ "$TARGETPLATFORM" = "linux/386" ]; then ARCH="i586"; \
# linux/arm64/v8 points to linux/arm64
elif [ "$TARGETPLATFORM" = "linux/arm64/v8" \
-o "$TARGETPLATFORM" = "linux/arm64" ]; then ARCH="aarch64"; \
# linux/arm translates to linux/arm/v7
elif [ "$TARGETPLATFORM" = "linux/arm/v7" ]; then ARCH="armv8"; \
elif [ "$TARGETPLATFORM" = "linux/arm/v6" ]; then ARCH="armv6"; \
elif [ "$TARGETPLATFORM" = "linux/amd64/v3" \
-o "$TARGETPLATFORM" = "linux/amd64/v2" \
-o "$TARGETPLATFORM" = "linux/amd64" ]; then ARCH="x86_64"; \
# we dont suppot any other arch so let it fail
else ARCH="unknown"; fi && \

@mgautierfr
Copy link
Member

Raspbian armhf means ARMv6 + VFPv2 while Debian armhf means ARMv7.

This confirms to me that we should stay with armv6 and armv8 and stop naming our build with armhf

@rgaudin
Copy link
Member

rgaudin commented Jun 9, 2023

Should we remove the 3.5.0 armhf file? It's broken, there's no update and from what I understand, there won't be.

I just got fooled updating the hotspot with the latest armhf

@kelson42
Copy link
Contributor

kelson42 commented Jun 10, 2023

@mgautierfr Can you please tell us which meaning of armhf is used (see https://github.com/offspot/container-images/wiki/Raspberry-Pi-Models)

Assuming we use the "Raspian meaning", I hope I understand all the aspects of this problem. Here would be what I would recommend:

@mgautierfr @rgaudin Does that makes sense? What else should be updated?

@rgaudin
Copy link
Member

rgaudin commented Jun 10, 2023

@kelson42 zim-tools image is x86_64 only

@Popolechien
Copy link
Member

I've replaced the armhf link with a link to kiwix-tools_linux-armv6-3.5.0-1.tar.gz but for future iterations it would be good to have a more generic redirect (e.g. kiwix-tools_linux-armv6.tar.gz) much like the others.

@kelson42
Copy link
Contributor

@rgaudin Can you please put the few additional redirects in place?

@rgaudin
Copy link
Member

rgaudin commented Jun 12, 2023

@rgaudin Can you please put the few additional redirects in place?

Done and deployed.
As of today, every single Kiwix and openZIM release file should have a version-less redirect.

@mgautierfr
Copy link
Member

Sorry about late reply but:

Remove armhf link in kiwix.org/en/downloads/kiwix-serve @Popolechien

It would be better to setup a redirection instead of removing ?

Add link to armv6 as offer for the ARM 32 bits at kiwix.org/en/downloads/kiwix-serve @Popolechien

What about armv8 ?
If we don't create a redirection for it, I suggest we don't build/publish it neither.

@kelson42
Copy link
Contributor

kelson42 commented Jun 16, 2023

@Popolechien Two things to fix:

  • « x86 ARM (64 bits) » does not exist. « ARM (64 bits) » does
  • All redirects are ready now, please use them
  • Add a sentence below the binary link like « Older and alternative (for other architectures) can be found at https://download.kiwix.org/release/kiwix-tools/ « .

@Popolechien
Copy link
Member

@kelson42 Done.

@kelson42
Copy link
Contributor

@rgaudin so i guess there is only the work on the two container images left.

@rgaudin
Copy link
Member

rgaudin commented Jun 16, 2023

@rgaudin so i guess there is only the work on the two container images left.

What work? This PR has been sitting there for 3 weeks. There's nothing left to do but merge

@kelson42
Copy link
Contributor

@rgaudin (1) Fix kiwix-tools (and kiwix-serve) container images (2) Fix zim-tools container images the same way.

I believe it has not been completed, or do you have PR for this?

@rgaudin
Copy link
Member

rgaudin commented Jun 16, 2023

@rgaudin (1) Fix kiwix-tools (and kiwix-serve) container images (2)

I'm sorry I really don't understand what you are talking about. This is #622

Fix zim-tools container images the same way.

That I haven't submitted a PR yet.

@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Jun 16, 2023
@kelson42
Copy link
Contributor

@rgaudin Thx, I have merged #622

@kelson42
Copy link
Contributor

@rgaudin I have created openzim/zim-tools#351 to request the improvement of container images on ZIM tools. That way we can also close this ticket. @holta Thank you for pointing the many bugs and weaknesses around the distribution of the Kiwix Tools binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants