Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't download music video? #104

Closed
weeee9 opened this issue Aug 22, 2020 · 4 comments
Closed

Can't download music video? #104

weeee9 opened this issue Aug 22, 2020 · 4 comments
Labels

Comments

@weeee9
Copy link

weeee9 commented Aug 22, 2020

Hi, I've found that when download a music video it will get the error: error parsing signature tokens
but there's no error when it's not a muisc video.

Is the google api changed or something?

I'm using v2.0.1 btw.

@clr1107
Copy link
Contributor

clr1107 commented Aug 22, 2020

I think it has, I've just found this error. I was looking at the functions, I think the decipher.go file will need to be updated. From what I can see, its deciphering methodology may have changed, the JSON response doesn't always contain a url for formats (qualities) to download. If it doesn't, it needs to be extracted. A nice JSON response would look like this:

"streamingData": {
        "expiresInSeconds": "21540",
        "formats": [
            {
                "itag": 18,
                "url": "https://r4---sn-aigl6n7s.googlevideo.com/videoplayback?e.....",
            },

But sometimes it contains a key signatureCipher instead, and there's a url encoded in there. If nobody else has any idea how to update it I might try, but right now I'm focusing on Playlists.

@clr1107 clr1107 mentioned this issue Aug 22, 2020
@Julian-Chu Julian-Chu added the bug label Aug 22, 2020
@Julian-Chu
Copy link
Collaborator

Hi @weeee9 and @clr1107 ,

thanks for the issue, we will try to solve it as soon as possible.

@Julian-Chu
Copy link
Collaborator

It looks like google add additional data property for embedded video player page, so the regex became invalid.
this should be fixed by #106
if any issue, please feel free to reopen this issue for v2.0.1

@Julian-Chu
Copy link
Collaborator

release v2.0.2 for this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants