bug: SHA3 VMTests failure

[greged93]

Bug Report

Kakarot version: ee6458a

Current behavior:
The sha3 test is expected to pass but fails. It has been determined that the issue comes from the fact that if a CALL opcode is performed with some expected return argument length, but the called contract doesn't return any value, this will result in a failure on the below line, during finalization of the calling context.

Expected behavior:
The test should pass.

Steps to reproduce:

• clone ef-tests: https://github.com/kkrt-labs/ef-tests
• run

make setup
make target=sha3_d0g0v0_Shanghai ef-test

The test should fail with

Transaction execution error: "Error in the called contract (0x04e2460d0debdacdde372cb598b4e4403939ca112c8720e1c2aca13f6ac09b9a):
Error at pc=0:7:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:163)
Unknown location (pc=0:149)

Error in the called contract (0x04e2460d0debdacdde372cb598b4e4403939ca112c8720e1c2aca13f6ac09b9a):
Error at pc=0:31:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:4606)
Unknown location (pc=0:4545)
Unknown location (pc=0:4374)
Unknown location (pc=0:376)

Error in the called contract (0x049c085e55e5ab05ea46e16706720852421e86c1f8aeeab2be257313c4e290f4):
Error at pc=0:2671:
Couldn't compute operand op1. Unknown value for memory cell 39:1
Cairo traceback (most recent call last):
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18091)
Unknown location (pc=0:16584)
Unknown location (pc=0:3321)

[!] Case ~/code/rust/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/VMTests/vmTests/sha3.json failed:
Test failed: sha3_d0g0v0_Shanghai expected storage value 0x00000000000000000000000000000000e500b653ca82273b7bfad8045d85a470 for 0x0000000000000000000000000000000000000100, got 0x0000000000000000000000000000000000000000000000000000000000000000

Other information:

Below is a link to the extended error message:
https://gist.github.com/jobez/b21a84a35e7c97eb0de98424506cd4ef#file-resultant_traceback-txt

[ClementWalter]

see kkrt-labs/kakarot#702

[Eikix]

Is this issue still ongoing?

[greged93]

I don't think anyone made a PR to fix it

[jobez]

We discussed a model for how to fix the bug, I will make sure that there is an issue with full details of the necessary fix and link back.

[jobez]

see: kkrt-labs/kakarot#718 (comment)

[Eikix]

What is the status of this @greged93, I think it's fixed

[greged93]

I think so too!