bug: performance tests hit RunResources has no remaining steps.

[greged93]

Bug Report

Kakarot version: ee6458a

Current behavior:
The VMTests/vmPerformance tests fail with RunResources has no remaining steps. The first test (performanceTester_d0g0v0_Shanghai) should be able to pass as the calculation is still very limited.

Expected behavior:
The test should pass at least up to performanceTester_d2g0v0_Shanghai, which tests the Ackermann recursive function with input (3,1), causing 15 recursive calls.

Steps to reproduce:

• clone ef-tests: https://github.com/kkrt-labs/ef-tests
• run

make setup
make fetch-dump
make tarket=performanceTester_d0g0v0_Shanghai ef-test
make tarket=performanceTester_d1g0v0_Shanghai ef-test
make tarket=performanceTester_d2g0v0_Shanghai ef-test

The above should fail with:

Transaction execution error: "Error in the called contract (0x04e2460d0debdacdde372cb598b4e4403939ca112c8720e1c2aca13f6ac09b9a):
Error at pc=0:7:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:163)
Unknown location (pc=0:149)

Error in the called contract (0x04e2460d0debdacdde372cb598b4e4403939ca112c8720e1c2aca13f6ac09b9a):
Error at pc=0:31:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:4606)
Unknown location (pc=0:4545)
Unknown location (pc=0:4374)
Unknown location (pc=0:376)

Error in the called contract (0x049c085e55e5ab05ea46e16706720852421e86c1f8aeeab2be257313c4e290f4):
Error at pc=0:4571:
Could not reach the end of the program. RunResources has no remaining steps.
Cairo traceback (most recent call last):
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18120)
Unknown location (pc=0:18022)
Unknown location (pc=0:17239)
"
[!] Case ~/code/rust/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/VMTests/vmPerformance/performanceTester.json failed (description: performanceTester): Test failed: failed test performanceTester_d0g0v0_Shanghai: expected storage value 0x000000000000000000000000000000000000000000000000000000000000003d, got 0x0000000000000000000000000000000000000000000000000000000000000000

Related code:
Here is are the code snippets executed by performanceTester_d0g0v0_Shanghai, performanceTester_d1g0v0_Shanghai and performanceTester_d2g0v0_Shanghai respectively:

pragma solidity ^0.8;
    // SPDX-License-Identifier: GPL-3.0
    // RETESTETH_SOLC_EVM_VERSION=berlin
    contract PerformanceTester {    
        uint result;

        function ackermann(uint m, uint n) public returns (uint) {
                if (m == 0)
                        return n + 1;
                
                if (n == 0)
                        return ackermann(m - 1, 1);
                
                return ackermann(m - 1, ackermann(m, n - 1));
        }
  
        function ack(uint m, uint n) public returns (uint) {
                result = ackermann(m,n);
                return result;
        }

        
        function fibonacci(uint n) public returns (uint) {
            if (n == 0 || n == 1)
                return n;

            return fibonacci(n - 1) + fibonacci(n - 2);
        }



        function fib(uint n) public returns (uint) {
            result = fibonacci(n);
            return 0x60A7;
        }
    }

• performanceTester_d0g0v0_Shanghai calls fib(10)
• performanceTester_d1g0v0_Shanghai calls fib(16)
• performanceTester_d2g0v0_Shanghai calls ack(3, 1)