Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: coinbase post-state #63

Closed
Tracked by #28
greged93 opened this issue Sep 2, 2023 · 1 comment
Closed
Tracked by #28

bug: coinbase post-state #63

greged93 opened this issue Sep 2, 2023 · 1 comment
Labels
runner bug Something related to normal test runner execution isn't working

Comments

@greged93
Copy link
Contributor

greged93 commented Sep 2, 2023

Bug Report

Kakarot version: ee6458a

Current behavior:
The envInfo test fail on the first test. This is due to a missing post state value corresponding to the coinbase address. It looks like the post state of the test takes into account any transfer of fees done to the coinbase address.

Expected behavior:
Test should pass for the envInfo which is currently under test (which doesn't concern the coinbase).

Steps to reproduce:

make setup
make fetch-dump
make target=envInfo_d0g0v0_Shanghai ef-test

Failing output should be:

[!] Case /Users/greg/code/rust/ef-tests/crates/ef-testing/ethereum-tests/BlockchainTests/GeneralStateTests/VMTests/vmTests/envInfo.json failed:
Test failed: missing evm address 0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba in post state storage
@greged93 greged93 added the runner bug Something related to normal test runner execution isn't working label Sep 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 2, 2023
@greged93 greged93 changed the title bug: bug: coinbase post-state Sep 2, 2023
@greged93 greged93 self-assigned this Sep 4, 2023
@greged93 greged93 moved this from 🆕 Backlog to 🏗 In progress in Kakarot on Starknet Sep 4, 2023
@greged93 greged93 moved this from 🏗 In progress to 🔖 Ready in Kakarot on Starknet Sep 11, 2023
@greged93 greged93 removed their assignment Oct 17, 2023
@Eikix Eikix moved this from 🔖 Ready to 🆕 Backlog in Kakarot on Starknet Dec 14, 2023
@greged93
Copy link
Contributor Author

Should be fixed now that we correctly handle the coinbase address.

@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner bug Something related to normal test runner execution isn't working
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant