Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create generic pow implementation #189

Closed
2 tasks
enitrat opened this issue Aug 25, 2023 · 2 comments
Closed
2 tasks

feat: Create generic pow implementation #189

enitrat opened this issue Aug 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Contributor

enitrat commented Aug 25, 2023

Feature Request

Create a generic implementation of pow over type T to avoid unnecessary code duplication. This will allow using all integer types in exponentiation operations.
This can not be performed natively for wrapping_pow as we can't use generics with libfuncs such as u256_overflow_mul. That would require adding a WrappingMath trait, but it's not a priority for now
Describe the Feature Request

Describe Preferred Solution

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

  • Yes
  • No
@Eikix
Copy link
Member

Eikix commented Sep 8, 2023

Important update: we are gathering some bugs in the Kakarot v0 codebase, we need to make sure each issue and each PR in Kakarot-ssj is aware of the lists of known bugs. Look at this tracking issue everytime you take an issue and check your issue isn't targeted by a known bug. Will add this reminder in many places to make sure we keep track of known bugs.

@Eikix
Copy link
Member

Eikix commented Oct 10, 2023

Closing in favor of #408

@Eikix Eikix closed this as completed Oct 10, 2023
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants