Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

dev: replace all *_div_rem by DivRem::div_rem #374

Closed
enitrat opened this issue Sep 27, 2023 · 1 comment · Fixed by #381
Closed

dev: replace all *_div_rem by DivRem::div_rem #374

enitrat opened this issue Sep 27, 2023 · 1 comment · Fixed by #381
Assignees
@khaeljy
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@enitrat
Copy link
Contributor

enitrat commented Sep 27, 2023

This improvement makes the codebase lighter by avoiding explicit imports of libfuncs and rely on the trait system to use the correct type
@enitrat enitrat added the enhancement New feature or request label Sep 27, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 27, 2023
@enitrat enitrat added the good first issue Good for newcomers label Sep 27, 2023
@khaeljy
Copy link
Contributor

khaeljy commented Sep 27, 2023

Can I do it, pls?

@Eikix Eikix moved this from 🆕 Backlog to 🏗 In progress in Kakarot on Starknet Sep 27, 2023
@khaeljy khaeljy mentioned this issue Sep 27, 2023
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Kakarot on Starknet Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khaeljy khaeljy

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Kakarot on Starknet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev: replace all *_div_rem by DivRem::div_rem khaeljy/kakarot-ssj
2 participants
@khaeljy @enitrat