Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SNIP-9 on account contracts #819

Closed
enitrat opened this issue Aug 8, 2024 · 7 comments
Closed

feat: support SNIP-9 on account contracts #819

enitrat opened this issue Aug 8, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@enitrat
Copy link
Contributor

enitrat commented Aug 8, 2024

@enitrat enitrat added the enhancement New feature or request label Aug 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Aug 8, 2024
@remybar
Copy link
Contributor

remybar commented Aug 8, 2024

Copy link

onlydustapp bot commented Aug 8, 2024

Hey @remybar!
Thanks for showing interest.
We've created an application for you to contribute to Kakarot zkEVM.
Go check it out on OnlyDust!

@enitrat
Copy link
Contributor Author

enitrat commented Aug 8, 2024

yes, and the reference implementation in Cairo Zero: https://github.com/kkrt-labs/kakarot/blob/7fb90d799a5a0bfab0a48bdfcb4e867d35b4943c/src/kakarot/accounts/account_contract.cairo#L83.

First try to migrate to a SNIP-9 compatible structure. For everything that can not trivially implemented, add a TODO and we'll create an issue.

@enitrat
Copy link
Contributor Author

enitrat commented Aug 18, 2024

@remybar how are things going?

@remybar
Copy link
Contributor

remybar commented Aug 19, 2024

@remybar how are things going?

Hi @enitrat
We finally took some holidays until end of August so I'll be back to work on issues end of August/beginning of September.

Do you need this feature earlier than that? If yes, I can push what I did if someone wants to continue.

@enitrat
Copy link
Contributor Author

enitrat commented Aug 19, 2024

yes please!

@remybar remybar mentioned this issue Aug 19, 2024
@remybar
Copy link
Contributor

remybar commented Aug 19, 2024

yes please!

I pushed what I've started in the following PR #836.

Sorry for the delay, I don't like to start a task and let it for several days/weeks 😕

@enitrat enitrat closed this as completed Sep 9, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants