Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find only cares about last search term #126

Closed
teschty opened this issue Feb 1, 2019 · 0 comments
Closed

Find only cares about last search term #126

teschty opened this issue Feb 1, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@teschty
Copy link

teschty commented Feb 1, 2019

Describe the bug
The --find option only returns items containing the last search term.

The documentation seems to suggest you should be able to use multiple search terms.

To Reproduce

tb --task one two three

tb --find blah blah two
  My Board [0/1]
   10. [ ]  one two three

tb --find two blah blah
(no results)

Expected behavior
I'm uncertain if find is supposed to require all search terms to be present or just require any one search term to be present.

If all search terms are required:

  • No results for both searches.

If only one search term is required:

  • Both searches should include the added task.

Technical Info (please complete the following information)

  • OS: Windows 10
  • Node.js Version: v10.8.0
  • Taskbook Version: 0.2.0

Additional context
This line appears to check if the search term is the last one in the array, and only sets the result value to a truthy value if it is.

@klaudiosinani klaudiosinani added the bug Something isn't working label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants