Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark GPU Processing Support #67

Open
CharlesHolbrow opened this issue Dec 6, 2023 · 0 comments
Open

Benchmark GPU Processing Support #67

CharlesHolbrow opened this issue Dec 6, 2023 · 0 comments
Milestone

Comments

@CharlesHolbrow
Copy link
Contributor

Originally I assumed that we would be keeping audio tensors on the GPU, so It made sense to pass tensors between audio transforms (consecutive transforms will be fused by beam and run in the same process). However since we've been doing most of our processing on the CPU this has not been necessary.

Now that I better understand beam concurrency it's worth taking a moment to revisit GPU support and just benchmark the cost of running some jobs on the GPU. I don't want to refactor away from torchaudio, and then refactor back later. If that seems likely, I would sooner add torch and torchaudio as optional package dependencies, and make LoadWithTorchaudio et al. contingent on these optional deps.

@CharlesHolbrow CharlesHolbrow added this to the v1.1 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant