-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing should not fail for a single parsing error #19
Comments
@joakimbeng do you have a opinion on that ? 😃 |
Sorry for my slow response :P I think you're right. Do you think it should log anything when a syntax error is found, or be totally quiet? |
In my opinion a gulp plugin shloud parse argv to catch the |
I'm not sure it should depend on |
Here's the handling of the same issue in gulp-sass by passing in an option {errLogToConsole: true}: |
Came across a issue where if you try to sort a stream of files where you have both your js and css the lib will fail silently. Example: I don't think it should even fail, don't parse non js files. |
https://github.com/klei/gulp-angular-filesort/blob/master/index.js#L24
Does this make sense to through this error instead of continuing ? If there is about 100 javascript files to sort, why breaking the whole processing just because of one file ?
The text was updated successfully, but these errors were encountered: