Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Allow custom EqualityComparer on ViewModelBase.Set<T>() function #112

Closed
SSchulze1989 opened this issue Jun 11, 2022 · 1 comment · Fixed by #113
Closed

Allow custom EqualityComparer on ViewModelBase.Set<T>() function #112

SSchulze1989 opened this issue Jun 11, 2022 · 1 comment · Fixed by #113
Labels
type: feature New feature or enhancement

Comments

@SSchulze1989
Copy link
Contributor

Feature description

The Set<T>() function does use the EqualityComparer<T>.Default default comparer which is great for most use-cases.
However if custom equality testing is required it means the function cannot be used.
With a simple overload it could be enabled to pass a custom comparer using the IEqualityComparer interface to the Set<T>() function without introducing any breaking changes.

Code sample

No response

@SSchulze1989 SSchulze1989 added status: triage Needs to be triaged type: feature New feature or enhancement labels Jun 11, 2022
@SSchulze1989
Copy link
Contributor Author

I have opened a pr with the required changes:
#113

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature New feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants