Skip to content

Use standard IPFS URIs #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaybuidl opened this issue Jan 25, 2024 · 1 comment
Closed

Use standard IPFS URIs #27

jaybuidl opened this issue Jan 25, 2024 · 1 comment
Labels
Package: Web Escrow web frontend Type: Enhancement ✨

Comments

@jaybuidl
Copy link
Member

All the IPFS URIs we have been using since v1 do not conform with the RFC3986 specs for URIs.

❌ /ipfs/QmZ3Cmnip8bmFNruuTuCdxPymEjyK9VcQEyf2beDYcaHaK/metaEvidence.json
✅ ipfs://QmZ3Cmnip8bmFNruuTuCdxPymEjyK9VcQEyf2beDYcaHaK/metaEvidence.json

It should be relatively easy to fix, and we could even have a fallback for backward-compatibility.
@jaybuidl jaybuidl mentioned this issue Jan 25, 2024
Closed
@kemuru
Copy link
Contributor

kemuru commented Feb 27, 2024

fixed

@kemuru kemuru closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: Web Escrow web frontend Type: Enhancement ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaybuidl @kemuru