refactor: errors rename

Author: jaybuidl

contracts/src/arbitration/dispute-kits/DisputeKitClassicBase.sol

@@ -729,7 +729,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
         bytes32 actualVoteHash = hashVote(_choice, _salt, _justification);
         for (uint256 i = 0; i < _voteIDs.length; i++) {
             if (disputes[_localDisputeID].rounds[_localRoundID].votes[_voteIDs[i]].commit != actualVoteHash)
-                revert HashDoesNotMatchHiddenVoteCommitment();
+                revert ChoiceCommitmentMismatch();
         }
     }
 
@@ -773,7 +773,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
     error NotVotePeriod();
     error EmptyVoteIDs();
     error ChoiceOutOfBounds();
-    error HashDoesNotMatchHiddenVoteCommitment();
+    error ChoiceCommitmentMismatch();
     error VoteAlreadyCast();
     error NotAppealPeriod();
     error NotAppealPeriodForLoser();

contracts/src/arbitration/dispute-kits/DisputeKitGatedShutter.sol

@@ -226,7 +226,7 @@ contract DisputeKitGatedShutter is DisputeKitClassicBase {
         bytes32 actualJustificationHash = hashJustification(_salt, _justification);
         for (uint256 i = 0; i < _voteIDs.length; i++) {
             if (justificationCommitments[_localDisputeID][_localRoundID][_voteIDs[i]] != actualJustificationHash)
-                revert WrongJustification();
+                revert JustificationCommitmentMismatch();
         }
     }
 
@@ -287,5 +287,5 @@ contract DisputeKitGatedShutter is DisputeKitClassicBase {
 
     error TokenNotSupported(address tokenGate);
     error EmptyJustificationCommit();
-    error WrongJustification();
+    error JustificationCommitmentMismatch();
 }

contracts/src/arbitration/dispute-kits/DisputeKitShutter.sol

@@ -182,7 +182,7 @@ contract DisputeKitShutter is DisputeKitClassicBase {
         bytes32 actualJustificationHash = hashJustification(_salt, _justification);
         for (uint256 i = 0; i < _voteIDs.length; i++) {
             if (justificationCommitments[_localDisputeID][_localRoundID][_voteIDs[i]] != actualJustificationHash)
-                revert WrongJustification();
+                revert JustificationCommitmentMismatch();
         }
     }
 
@@ -191,5 +191,5 @@ contract DisputeKitShutter is DisputeKitClassicBase {
     // ************************************* //
 
     error EmptyJustificationCommit();
-    error WrongJustification();
+    error JustificationCommitmentMismatch();
 }

contracts/test/arbitration/helpers/dispute-kit-shutter-common.ts

@@ -502,7 +502,7 @@ export function testNormalFlowBotReveals(context: () => ShutterTestContext) {
             ctx.salt,
             ctx.justification
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "HashDoesNotMatchHiddenVoteCommitment");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "ChoiceCommitmentMismatch");
       });
 
       it("Should revert if wrong salt provided", async () => {
@@ -528,7 +528,7 @@ export function testNormalFlowBotReveals(context: () => ShutterTestContext) {
             wrongSalt, // Wrong salt
             ctx.justification
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "HashDoesNotMatchHiddenVoteCommitment");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "ChoiceCommitmentMismatch");
       });
 
       it("Should revert if wrong justification provided", async () => {
@@ -554,7 +554,7 @@ export function testNormalFlowBotReveals(context: () => ShutterTestContext) {
             ctx.salt,
             wrongJustification // Wrong justification
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "WrongJustification");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "JustificationCommitmentMismatch");
       });
 
       it("Should revert if vote already cast", async () => {
@@ -675,7 +675,7 @@ export function testRecoveryFlowJurorReveals(context: () => ShutterTestContext)
             ctx.salt,
             ""
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "HashDoesNotMatchHiddenVoteCommitment");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "ChoiceCommitmentMismatch");
       });
 
       it("Should revert if wrong salt in recovery", async () => {
@@ -701,7 +701,7 @@ export function testRecoveryFlowJurorReveals(context: () => ShutterTestContext)
             wrongSalt, // Wrong salt
             ""
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "HashDoesNotMatchHiddenVoteCommitment");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "ChoiceCommitmentMismatch");
       });
 
       it("Should revert if non-juror tries to reveal without correct full commitment", async () => {
@@ -727,7 +727,7 @@ export function testRecoveryFlowJurorReveals(context: () => ShutterTestContext)
             ctx.salt,
             "" // No justification - would work for juror but not for others
           )
-        ).to.be.revertedWithCustomError(ctx.disputeKit, "WrongJustification");
+        ).to.be.revertedWithCustomError(ctx.disputeKit, "JustificationCommitmentMismatch");
       });
     });
   });
@@ -846,7 +846,7 @@ export function testEdgeCasesAndSecurity(context: () => ShutterTestContext) {
           ctx.salt,
           ctx.justification
         )
-      ).to.be.revertedWithCustomError(ctx.disputeKit, "HashDoesNotMatchHiddenVoteCommitment");
+      ).to.be.revertedWithCustomError(ctx.disputeKit, "ChoiceCommitmentMismatch");
     });
   });
 }

contracts/test/foundry/KlerosCore_Voting.t.sol

@@ -114,11 +114,11 @@ contract KlerosCore_VotingTest is KlerosCore_TestBase {
 
         // Check the require with the wrong choice and then with the wrong salt
         vm.prank(staker1);
-        vm.expectRevert(DisputeKitClassicBase.HashDoesNotMatchHiddenVoteCommitment.selector);
+        vm.expectRevert(DisputeKitClassicBase.ChoiceCommitmentMismatch.selector);
         disputeKit.castVote(disputeID, voteIDs, 2, salt, "XYZ");
 
         vm.prank(staker1);
-        vm.expectRevert(DisputeKitClassicBase.HashDoesNotMatchHiddenVoteCommitment.selector);
+        vm.expectRevert(DisputeKitClassicBase.ChoiceCommitmentMismatch.selector);
         disputeKit.castVote(disputeID, voteIDs, YES, salt - 1, "XYZ");
 
         vm.prank(staker1);