Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upstream contribution] Support ormb in Seldon Core and KFServing #25

Closed
gaocegege opened this issue Jun 4, 2020 · 12 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@gaocegege
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

ormb should be able to be used in KFServing and Seldon Core to pull/push models.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@gaocegege
Copy link
Member Author

/priority p0

@caicloud-bot caicloud-bot added the priority/P0 Highest priority. Must be actively worked on as someone's top priority right now. label Jun 4, 2020
@gaocegege
Copy link
Member Author

@gaocegege
Copy link
Member Author

Seldon Core already supports multiple storage backend here github.com/SeldonIO/seldon-core/python/seldon_core/storage.py, thus it should not be hard to support ormb.

Doc is here https://docs.seldon.io/projects/seldon-core/en/v1.1.0/reference/release-0.4.0.html?highlight=s3#prepackaged-model-servers

@ddysher
Copy link
Member

ddysher commented Jun 8, 2020

Is there any upstream tracking issue?

@gaocegege
Copy link
Member Author

No, going to request a demo show slot in seldon core community call. Now do not have the bandwidth for it currently. I think we should have a blog post in English for it first, then the community members can know more about our project.

@ddysher
Copy link
Member

ddysher commented Jun 8, 2020

ok, SGTM

@gaocegege
Copy link
Member Author

We decide to implement it in our fork first to provide the end-to-end prototype.

@gaocegege gaocegege self-assigned this Jun 10, 2020
@gaocegege
Copy link
Member Author

Ref #34

KFServing and Seldon Core download the model using Python code. Now we will implement our own initializer using Golang.

@gaocegege
Copy link
Member Author

We have to fork the seldon-core to support auth for ormb. Ref gaocegege/seldon-core#2

@gaocegege
Copy link
Member Author

Now we succeed to run Seldcon Core deployment with ormb in gaocegege/seldon-core#2 . But we have some modifications for it. Maybe we should try to:

@gaocegege
Copy link
Member Author

We do not need to modify seldon core code. Things we need to do for the issue is to present it in Seldon Core community.

@gaocegege gaocegege added kind/feature Categorizes issue or PR as related to a new feature. priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/P0 Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 15, 2020
@gaocegege
Copy link
Member Author

ref #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P2 Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants