Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have hist_vars_for_precond_list return set (and rename) #86

Open
klindsay28 opened this issue Oct 11, 2023 · 0 comments
Open

have hist_vars_for_precond_list return set (and rename) #86

klindsay28 opened this issue Oct 11, 2023 · 0 comments

Comments

@klindsay28
Copy link
Owner

Implementation of hist_vars_for_precond_list would be easier if it returned a set.
I.e., let python take care of checking to see if varname is already in res,
instead of explicitly needing to check.
Additionally, usage of the returned value only requires that it is iterable, which sets are.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klindsay28