Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure reloading modules reloads all (also transitive) module dependencies #222

Closed
klmr opened this issue Jul 26, 2021 · 0 comments · Fixed by #226
Closed

Ensure reloading modules reloads all (also transitive) module dependencies #222

klmr opened this issue Jul 26, 2021 · 0 comments · Fixed by #226
Assignees
@klmr
Labels
⚠️ bug

Comments

@klmr
Copy link
Owner

klmr commented Jul 26, 2021 •
edited
Loading

Currently the draft implementation (#195) does not handle reloading transitive module dependencies. Fixing this requires recursively unloading each import’s imports in turn.
@klmr klmr self-assigned this Jul 26, 2021
@klmr klmr changed the title Ensure reloading modules reloads all (also transitive) submodules Ensure reloading modules reloads all (also transitive) module dependencies Jul 28, 2021
@klmr klmr mentioned this issue Aug 1, 2021
Merged
@klmr klmr closed this as completed Aug 1, 2021
@klmr klmr linked a pull request Aug 1, 2021 that will close this issue
Reload submodules #226
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klmr klmr

Labels
⚠️ bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reload submodules klmr/box
1 participant
@klmr