Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdmobInterstitialPlugin can crash on didFailToReceiveAdWithError #65

Closed
kmcgill88 opened this issue Sep 11, 2019 · 2 comments · Fixed by #66
Closed

AdmobInterstitialPlugin can crash on didFailToReceiveAdWithError #65

kmcgill88 opened this issue Sep 11, 2019 · 2 comments · Fixed by #66
Assignees
@kmcgill88
Labels
bug Something isn't working iOS Only effects iOS

Comments

@kmcgill88
Copy link
Owner

The AdmobInterstitialPlugin didFailToReceiveAdWithError caused my app to crash when an adblocker was running on the network. I'm assuming the GADRequestError can't be passed through the platform channel. See docs for allowed types over platform channel.
@kmcgill88 kmcgill88 added bug Something isn't working iOS Only effects iOS labels Sep 11, 2019
@kmcgill88 kmcgill88 self-assigned this Sep 11, 2019
@kmcgill88
Copy link
Owner Author

Confirmed my hunch. Will have a PR fix momentarily.

2019-09-11 20:27:22.155377-0500 Runner[85257:1657437] *** Assertion failure in -[FlutterStandardWriter writeValue:], ../../flutter/shell/platform/darwin/common/framework/Source/FlutterStandardCodec.mm:330
2019-09-11 20:27:22.213879-0500 Runner[85257:1657437] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Unsupported value for standard codec'

@kmcgill88 kmcgill88 mentioned this issue Sep 12, 2019
Merged
@oliverbytes
Copy link

Thanks a lot for the fix and version bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcgill88 kmcgill88

Labels
bug Something isn't working iOS Only effects iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on ad fail
2 participants
@oliverbytes @kmcgill88