-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added modules for some common operator pools, lattice Hamiltonians, and other ADAPT variants #1
Conversation
In the variant RandomADAPT, the ansatz is grown by choosing randomly when the largest score (gradient) is degenerate
I realized the pull request just shows up as a regular Github issue and I can type comments write here. ^_^ I presently have three simple requests, and two somewhat more involved:
|
Speaking of tests, I've remembered there are two more things to worry about when adding code to TestsIn the I've already got a nice infrastructure set up to check for internal consistency; you can probably model your testset after the one for Overlap and OptimizationFree. Although it sure looks to me like there's a typo in the OptimizationFree test, and I'm a bit puzzled how that hasn't caused problems... Anyway, right before you make any pushes, it's a good practice to run the tests, by starting up a fresh Julia REPL and including the |
DocsInside of I think that's all you should have to do there... |
Also, super sorry to be nit-picky but I just realized a few more minor items:
|
…l script to test folder Created a separate Hamiltonians module, included everything that was in Operators in `Pools` (previously, OperatorPools), moved tiling_XXZ.jl into the test folder, removed the Combinatorics dependency (was unnecessary), removed .DS_store
Moved Hubbard definition into latticemodels.jl from pools.jl, added the documentation to docs
Renamed randomADAPT and its directories and files to the more appropriate `degenerateADAPT`
Added three functions: Base.:≈ and two otimes functions that should ultimately be added to the PauliOperators.jl package
Updated the Hubbard QEB tutorial script to use the Hamiltonian and pool defined in ADAPT.Hamiltonians and ADAPT.Pools respectively
Removed changes to .gitignore
Added a testset for the module Degenerate_ADAPT, test successful
Need to fix qubit ADAPT pool and decide location for tile_operators function
Added