Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test qaoa #6

Merged
merged 14 commits into from
Jun 6, 2024
Merged

Test qaoa #6

merged 14 commits into from
Jun 6, 2024

Conversation

yzchen-phy
Copy link
Contributor

Separate graph generation and MaxCut Hamiltonian generation to be more flexible. Can use Graphs.jl package to generate the graph for MaxCut.
Put ADAPT-QAOA types of pools (including the standard QAOA mixer) under ADAPT-QAOA module.

@kmsherbertvt
Copy link
Owner

kmsherbertvt commented Jun 6, 2024

@yzchen-phy Please consider the following changes before I accept the pull request:

  1. We need only have the one example script for qaoa; please replace test/maxcut_qaoa.jl with your test/maxcut_qaoa1.jl. (Different methods to accomplish things can be included as comments.)

  2. Add new modules you've defined (even if they are sub-modules) to the docs/src/index.mdfile.

  3. Avoid using packages, or if you do, please explicitly wrap the file into its own module, to contain the bloated namespace.

@@ -34,6 +34,7 @@ Modules = [
ADAPT.Degenerate_ADAPT,
ADAPT.TETRIS_ADAPT,
ADAPT.ADAPT_QAOA,
ADAPT.ADAPT_QAOA.QAOApool,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an s

(I am just exploring the interface here, don't mind me. I'm guessing this comment is going to have some link to the actual line of code?)

@kmsherbertvt
Copy link
Owner

I do seem to have found a spot in the interface which lets me "edit" the file, but it seems to actually be on Yanzhu's fork (which makes sense), and I'm guessing Yanzhu would have had to approve the change for it to actually be committed... We can try it out next time. :)

@kmsherbertvt kmsherbertvt merged commit 70f7a6b into kmsherbertvt:main Jun 6, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants