Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/lineinput.rbをlib/review/lineinput.rbに統合する #1600

Closed
kmuto opened this issue Nov 15, 2020 · 3 comments
Closed

lib/lineinput.rbをlib/review/lineinput.rbに統合する #1600

kmuto opened this issue Nov 15, 2020 · 3 comments

Comments

@kmuto
Copy link
Owner

kmuto commented Nov 15, 2020

汎用ライブラリにする必要もなさそうですし、lib/review/lineinput.rbに統合するのはいかがでしょう。
@takahashim
Copy link
Collaborator

これをするなら #1599 はマージしない方がよいかと思いますが、どうしましょうか？（統合についてはどちらでもOKです）

@kmuto
Copy link
Owner Author

kmuto commented Nov 15, 2020

方針としてよさそうなら、履歴にこだわりはないので #1599 に混ぜてしまおうかと…

@kmuto kmuto mentioned this issue Nov 15, 2020
Merged
@kmuto
Copy link
Owner Author

kmuto commented Nov 15, 2020

#1601 を作りました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takahashim @kmuto