use ReVIEW::Converter instead of system("review-compile ...") #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ReVIEW::Configure: add some default values * ReVIEW::EPUBMaker, ReVIEW::PDFMaker: basedir should be same as yamlfile * ReVIEW::EPUBMaker: stop building when error occured in compile *.re files.
|
それと、config.ymlの |
|
ありがとうございます。paramsは最近のだともう使ってることはないので大丈夫かな。 共有化による現象はちょっと怖いところですが、それで何か起きたら直すべきバグというのもわかるか…。 |
* remove `load_builder` method from ReVIEW::Converter. * easy to pass parameters to Builder object.
takahashim
added a commit
that referenced
this pull request
Mar 17, 2016
use ReVIEW::Converter instead of system("review-compile ...")
|
とりいそぎマージしてみました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReVIEW::Configure: add some default valuesReVIEW::EPUBMaker,ReVIEW::PDFMaker: basedir should be same as yamlfileReVIEW::EPUBMaker: stop building when error occured in compile *.re files.review-epubmakerとreview-pdfmakerで、内部的にreview-compileを呼ぶのを止めて、compile用のReVIEW::Converterクラスを使うようにするものです。
review-epubmakerは5倍くらいは速くなりそうです(review-pdfmakerはLaTeX側処理が圧倒的に時間がかかっているのであんまり変わらない)。
ただし、review-compileは別コマンドを呼ぶことによってBookオブジェクト等が共有されていなかったのですが、ReVIEW::Converterでは積極的に共有する形にしているので、思わぬ結果になる可能性があります。