Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove backward compatibility #560

Merged
merged 2 commits into from
Apr 17, 2016
Merged

remove backward compatibility #560

merged 2 commits into from
Apr 17, 2016

Conversation

takahashim
Copy link
Collaborator

  • layout.erb -> layout.html.erb
  • locale.yaml -> locale.yml
  • PageMetric.a5 -> PageMetric::A5

cf. #546

@takahashim
remove backward compatibility
dfd28f4 
* layout.erb -> layout.html.erb
* locale.yaml -> locale.yml
* PageMetric.a5 -> PageMetric::A5
@takahashim
Copy link
Collaborator Author

差し障りのなさそうなものだけで、 #546 で挙げられているものが全部入っているわけではないです。

@kmuto
Copy link
Owner

kmuto commented Apr 17, 2016

とりあえずこの範囲では問題ないかな。
リリースノートには注意が必要かも。

@takahashim
Copy link
Collaborator Author

@kmuto 「こっちはobsoleteだからこっちを使え」みたいなエラーを出した方がよいですか？（これは置き換え方法が明確なので）

@kmuto
Copy link
Owner

kmuto commented Apr 17, 2016

たしかに「locale.yaml」については出したほうが親切だと思います。

@kmuto
Copy link
Owner

kmuto commented Apr 17, 2016

👍

@takahashim takahashim merged commit 87a3fb4 into master Apr 17, 2016
@takahashim takahashim deleted the compat-layout branch April 17, 2016 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto