use read BOM|utf-8 flag for opening files, instead of string replacing #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,7 @@ def initialize(book, number, name, path, io = nil) | |||
| @content = nil | |||
| end | |||
| if !@content && @path && File.exist?(@path) | |||
| @content = File.read(@path).sub(/\A\xEF\xBB\xBF/u, '') | |||
| @content = File.open(@path, 'r:BOM|utf-8').read | |||
There was a problem hiding this comment.
ここはたぶん
@content = File.read(@path, :mode=>'r:BOM|utf-8')
でいけるはずです。というかFile.readを使わずFile.open(...).readすると、openしたファイルが閉じられないのであまりおすすめではないのでした。
@content = File.read(@path, mode: 'r:BOM|utf-8')
でもよいです(rubocopの警告がでなければ、こっちの方が読みやすいのでおすすめ)。
|
おぉ、modeでいけるのですね。readは:encodingしかないのかと思っていました。 |
| @@ -26,7 +26,7 @@ def initialize(book, number, chapters, name = "", io = nil) | |||
| if io | |||
| @content = io.read | |||
| elsif @path && File.exist?(@path) | |||
| @content = File.read(@path).sub(/\A\xEF\xBB\xBF/u, '') | |||
| @content = File.read(@path, 'r:BOM|utf-8') | |||
There was a problem hiding this comment.
ここの引数の書き方は、lib/review/book/chapter.rb でコメントしたような、:modeをキーにしたハッシュにしないとエラーになるはずです（Hashと解釈されない値を第2引数にするとlengthに解釈されて数値じゃないとダメなはず）。
|
ではこれでマージしますね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows向けに処理。
ちょっと怖いのでドキュメントでテストが必要。