Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/epubmaker/producer.rb で循環参照のwarning #599

Closed
kdmsnr opened this issue Apr 26, 2016 · 5 comments
Closed

lib/epubmaker/producer.rb で循環参照のwarning #599

kdmsnr opened this issue Apr 26, 2016 · 5 comments
Milestone

Comments

@kdmsnr
Copy link
Collaborator

kdmsnr commented Apr 26, 2016

Re:VIEWとepubmakerが相互に参照しているので、すべて lib/review 以下に入れたほうがよさそう?

@kmuto
Copy link
Owner

kmuto commented Apr 26, 2016

手元でepubmaker流用で使ってたのはだいたいreview-epubmakerに移行したから、移動してもいいかなぁ。ただちょっともう時間が足りないのでrelease後ですね(epubmaker.rbあたりが名前衝突して厄介なはず)。

@takahashim
Copy link
Collaborator

warningは出なくするだけならrequireの向きを直すだけでもいけるかもです

@kdmsnr
Copy link
Collaborator Author

kdmsnr commented Apr 26, 2016

lib/epubmaker/producer.rb で require 'review'してるんですが、それだけでreviewのすべてのファイルを読み込みます。で、その配下にある lib/review/epubmaker.rb で逆方向に require 'epubmaker' してるから循環してるっぽいです。

@kdmsnr
Copy link
Collaborator Author

kdmsnr commented Apr 26, 2016

epubcommon.rb の require 'epubmaker/producer' も不要そう。

@kdmsnr
Copy link
Collaborator Author

kdmsnr commented Apr 26, 2016

とりあえず全部とりました。

@kdmsnr kdmsnr closed this as completed Apr 26, 2016
@kdmsnr kdmsnr added this to the 2.0.0 milestone Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants