Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing newlines are not fixed by the formatter #147

Closed
kmyk opened this issue Aug 5, 2021 · 2 comments
Closed

Trailing newlines are not fixed by the formatter #147

kmyk opened this issue Aug 5, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@kmyk
Copy link
Collaborator

kmyk commented Aug 5, 2021 •
edited
Loading

なんで？ 変な差分が出るとよくないのでなんとかしたい。フォーマッタである Ormolu 側でなんとかすべきだと思うが、とりあえずは .editorconfig を足してかつ scripts/pre-commit の中で簡単に検査するのがいいと思う
@uta8a すまん……
ref #143
@kmyk kmyk added the good first issue Good for newcomers label Aug 5, 2021
@kmyk
Copy link
Collaborator Author

kmyk commented Aug 5, 2021

I've reported to Ormolu tweag/ormolu#741

@kmyk kmyk changed the title trailing newline が検査されていない Trailing newlines are not fixed by the formatter Aug 5, 2021
@kmyk
Copy link
Collaborator Author

kmyk commented Aug 6, 2021

trailing newline が足されないのは勘違いだったみたい。なんでだろう？ この issue はひとまず閉じて、再発したらまた考えることにしたい

@kmyk kmyk closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmyk