Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 9 upgrade to Twig 2.0 #63

Closed
juranosaurustechs opened this issue May 20, 2020 · 6 comments
Closed

Drupal 9 upgrade to Twig 2.0 #63

juranosaurustechs opened this issue May 20, 2020 · 6 comments

Comments

@juranosaurustechs
Copy link
Contributor

juranosaurustechs commented May 20, 2020

Given that Drupal 9 is upgrading to Twig to 2.0, will twig-renderer also need to be upgraded to Twig 2.0 syntax to update from old Twig_Function and Twig_Filter classes/interfaces to the new \Twig\TwigFunction and \Twig\TwigFilter respectively?

For reference: https://www.drupal.org/docs/9/how-to-prepare-your-drupal-7-or-8-site-for-drupal-9/preparing-for-use-of-twig-2-in-drupal-9#s-major-changes-include

@juranosaurustechs
Copy link
Contributor Author

I just figured out that Twig version is set in composer.json. So what is then best practice to upgrade that to Twig 2.0? or will it matter?

@mariohernandez
Copy link

I would also be interested in how to get Pattern Lab upgraded to Twig 2.0

@juranosaurustechs
Copy link
Contributor Author

Hi Mario, as I mentioned on twitter you can use https://github.com/rogeriochaves/npm-force-resolutions to force PL to use twig renderer 2.0.0. Or just DM me on Drupal Twig (or Chaz has my contact info) and I'll be happy to walk you through it.

@lquessenberry
Copy link

I am new to Knapsack, but I would also like to do this as well. I have a Composer/PHP version of PL (2.6) and I would like to replace it with patternlab-node (3.x)

@andriokha
Copy link

I just wanted to mention that it looks like Twig 2 is supported since #64. I don't know if there are any deprecations that ought to be handled, but otherwise I guess this issue could be closed?

@greylabel
Copy link
Contributor

Twig 3 is now supported in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants