Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Broker/Trigger dependency #46

Open
lionelvillard opened this issue Nov 16, 2020 · 17 comments
Open

Remove Broker/Trigger dependency #46

lionelvillard opened this issue Nov 16, 2020 · 17 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@lionelvillard
Copy link
Contributor

The autoscaler controller fails to start when eventing is not installed:

E1116 19:40:02.645081       1 reflector.go:178] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:125: Failed to list *v1.Broker: the server could not find the requested resource (get brokers.eventing.knative.dev)
E1116 19:40:02.673676       1 reflector.go:178] k8s.io/client-go@v12.0.0+incompatible/tools/cache/reflector.go:125: Failed to list *v1.Trigger: the server could not find the requested resource (get triggers.eventing.knative.dev)

Feature Request: remove dependency on Knative eventing. For instance I should be able to install just KafkaSource, KEDA and this project.

@zroubalik
Copy link
Contributor

Knative Eventing is not a requirement for using KafkaSource?

@lionelvillard
Copy link
Contributor Author

It used to, but not anymore.

@zroubalik
Copy link
Contributor

Interesting, the same applies to the rest of the Sources, or it is just KafkaSource specific?

@lionelvillard
Copy link
Contributor Author

AFAIK, all sources except the core ones (PingSource, APIServerSource, ...)

@zroubalik
Copy link
Contributor

zroubalik commented Nov 18, 2020

OK, then we should make the Trigger&Broker controller dynamic, the same way it is being done for the Sources

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2021
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 1, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2021
@github-actions github-actions bot closed this as completed Jul 1, 2021
@zroubalik zroubalik reopened this Jul 7, 2021
@github-actions github-actions bot closed this as completed Aug 7, 2021
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@zroubalik zroubalik reopened this Aug 11, 2021
@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2021
@zroubalik
Copy link
Contributor

/reopen

@knative-prow-robot
Copy link

@zroubalik: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2022
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2022
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2022
@pierDipi
Copy link
Member

/remove-lifecycle stale
/triage accepted
/reopen

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jul 11, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 11, 2022

@pierDipi: Reopened this issue.

In response to this:

/remove-lifecycle stale
/triage accepted
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot reopened this Jul 11, 2022
@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

4 participants