Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining topic prefix for Kafka Broker and KafkaChannel #3153

Closed
pierDipi opened this issue Jun 15, 2023 · 2 comments · Fixed by #3162
Closed

Allow defining topic prefix for Kafka Broker and KafkaChannel #3153

pierDipi opened this issue Jun 15, 2023 · 2 comments · Fixed by #3162
Assignees
Labels
area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@pierDipi
Copy link
Member

Problem

Currently, topic names are auto-generated with a prefix based on the resource name and namespace.

This makes difficult to use the same Apache Kafka cluster with multiple Knative Eventing installations in different Kubernetes clusters.

Similarly to 293b798, we could define in config-kafka-features topic names template:

brokers.topic.template: "knative-broker-{{ .Namespace }}-{{ .Name }}"
channels.topic.template: "knative-messaging-kafka.{{ .Namespace }}.{{ .Name }}"

and then use those templates for the underlying topic of Kafka Broker or KafkaChannel.

This will allow users to change the template for each Eventing installation.

Persona:
Which persona is this feature for?
System Operator

Exit Criteria

New tests are added that verify that by changing the template, the used topic are different from the default one.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
2

Additional context (optional)

/area broker
/area channel
/area control-plane

@knative-prow knative-prow bot added area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/control-plane labels Jun 15, 2023
@matzew
Copy link
Contributor

matzew commented Jun 15, 2023

Each broker installation could than have their own topics, in a centralized kafka system

@Cali0707
Copy link
Member

/assign

@pierDipi pierDipi added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Issues which should be fixed (post-triage) labels Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker Kafka Broker related issues area/channel Kafka Channel related issues area/control-plane help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants