Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] TestBrokerWithConfig should not rely on strimzi Topic Operator creating KafkaTopic #3592

Open
maschmid opened this issue Jan 11, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@maschmid
Copy link
Contributor

Describe the bug
https://github.com/knative-extensions/eventing-kafka-broker/blob/main/test/e2e_new/broker_config_test.go / https://github.com/knative-extensions/eventing-kafka-broker/blob/main/test/rekt/features/broker_config.go#L58

expects KafkaTopic to be created by Strimzi Topic operator based on the kafka topic created via the kafka admin client.

This behavior will not work anymore in new strimzi "Unidirectional Topic Operator", see https://strimzi.io/blog/2023/11/02/unidirectional-topic-operator/ , so the tests should not depend on it.

Expected behavior
TestBrokerWithConfig passes even with new Strimzi "Unidirectional Topic Operator"

To Reproduce

Knative release version
1.11

Additional context
We should disable TestBrokerWithConfig until we find a better way of asserting actual kafka topic configuration from within the e2e test.

There are at least two options:

  • Using a kafka admin client from inside the test. This will be problematic, as the e2e test can run outside of the cluster, with the Kafka being deployed inside the cluser (You don't just port-forward to a Kafka cluster... )
  • Using something like https://github.com/provectus/kafka-ui , to expose kafka cluster metadata that could be exposed to the e2e test running externally.
@maschmid maschmid added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2024
@maschmid maschmid changed the title TestBrokerWithConfig should not rely on strimzi Topic Operator creating KafkaTopic [test] TestBrokerWithConfig should not rely on strimzi Topic Operator creating KafkaTopic Jan 11, 2024
@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants