-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[control-plane]: Use filtered informer to watch OIDC service accounts #3655
Labels
Comments
/assign |
/assign |
Hello @karkabbage and @yijie-04, |
Hello @karkabbage, |
github-project-automation
bot
moved this from 🔖 Ready
to ✅ Done
in Eventing Sender Identity
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we're watching all service accounts in the cluster for changes and reenque the objects which have an OIDC service account assigned if something changes:
eventing-kafka-broker/control-plane/pkg/reconciler/trigger/controller.go
Lines 145 to 149 in 45c65c8
and
eventing-kafka-broker/control-plane/pkg/reconciler/trigger/namespaced_controller.go
Lines 141 to 144 in 45c65c8
Instead we should use a filtered service account informer as done in knative/eventing#7341
Additional information:
AuthStatus
#3521 done firstAuthStatus
#3658The text was updated successfully, but these errors were encountered: