Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-plane] Update TokenVerifier to check for the allowed subjects too #4042

Closed
creydr opened this issue Aug 7, 2024 · 3 comments · Fixed by #4061
Closed

[data-plane] Update TokenVerifier to check for the allowed subjects too #4042

creydr opened this issue Aug 7, 2024 · 3 comments · Fixed by #4061
Assignees
Labels
area/data-plane triage/accepted Issues which should be fixed (post-triage)

Comments

@creydr
Copy link
Contributor

creydr commented Aug 7, 2024

The TokenVerifier class needs to be updated to provide a way to check for valid authorization too.

Additional hints for new contributors before starting with this issue:

  1. When the issue has the Draft status, the issue is subject to change and thus should not be started to be worked on
  2. Make sure you've read and understood the CONTRIBUTING.md guidelines
  3. Make sure you're able to run Knative Eventing locally with Knative Eventing Kafka and run at least the unit tests.
  4. Feel free to raise any questions you have either directly here in the issue, in the #knative-eventing Slack channel or join the Eventing Workgroup Meeting / Office Hours
  5. When you feel comfortable with this issue, feel free to assign it to you (e.g. by commenting /assign). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.
@creydr
Copy link
Contributor Author

creydr commented Aug 7, 2024

/assign

@creydr
Copy link
Contributor Author

creydr commented Aug 7, 2024

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Aug 7, 2024
@Cali0707
Copy link
Member

/area data-plane

@creydr creydr moved this from 📝 Draft to 🔖 Ready in Eventing Authorization Aug 13, 2024
@creydr creydr moved this from 🔖 Ready to 🏗 In progress in Eventing Authorization Aug 13, 2024
@creydr creydr moved this from 🏗 In progress to 👀 In review in Eventing Authorization Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Eventing Authorization Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants