Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[mtsource] Do not cancel stadapter when only the # of replicas changes #647

Open
lionelvillard opened this issue May 24, 2021 · 4 comments
Open

[mtsource] Do not cancel stadapter when only the # of replicas changes #647

lionelvillard opened this issue May 24, 2021 · 4 comments
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@lionelvillard
Copy link
Contributor

Problem
The stadapter is always stopped when the KafkaSource spec changes. This is not always needed, specially when just the number of replicas changes

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.
@lionelvillard lionelvillard changed the title [mtsource] Does not cancel stadapter when only the # of replicas changes [mtsource] Do not cancel stadapter when only the # of replicas changes May 26, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2021
@lionelvillard
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2021
@lionelvillard
Copy link
Contributor Author

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2021
@lionelvillard lionelvillard added the triage/accepted Issues which should be fixed (post-triage) label Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lionelvillard @knative-prow-robot