Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

KafkaChannel reconciler creates Kafka client too often #912

Open
aliok opened this issue Oct 1, 2021 · 2 comments
Open

KafkaChannel reconciler creates Kafka client too often #912

aliok opened this issue Oct 1, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)

Comments

@aliok
Copy link
Member

aliok commented Oct 1, 2021

Describe the bug
KafkaChannel reconciler creates Kafka client too often. ...in every reconciliation loop.
Storing the client and reusing breaks things. See discussion here: #886 (comment)

Expected behavior
Not too many Kafka clients created

To Reproduce
See discussion here: #886 (comment) and apply the reverted change.

Knative release version
0.24, 0.25, 0.26

Additional context
See discussion here: #886 (comment)

@aliok aliok added the kind/bug Categorizes issue or PR as related to a bug. label Oct 1, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2021
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow-robot knative-prow-robot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants