Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The in-cluster-sender should properly wait and report state of sender job #130

Closed
cardil opened this issue Dec 22, 2021 · 2 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@cardil
Copy link
Contributor

cardil commented Dec 22, 2021

Currently, the code fails to wait until a sender job completely fails or manage to succeed in a retry.

https://github.com/knative-sandbox/kn-plugin-event/blob/6d85cfd3588b76bebb2a05b5d345c4eb4a468e21/pkg/k8s/jobrunner.go#L76-L83

Instead, the code should wait for the configured number of retries, and report failures of retries concisely.

Only in case of complete failure, a final error should be produced as described in #129.

/kind bug

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2021
@cardil cardil mentioned this issue Dec 23, 2021
@mgencur
Copy link

mgencur commented Feb 2, 2022

Also, when the job actually fails, the error string is repeated multiple times. This output comes from using the plugin from kn client when the job fails:

Error: can't sent event: can't send with ICS sender: the ICS job runner has failed: the ICS job runner has failed: the ICS job runner has failed: expected to have successful job

@github-actions
Copy link

github-actions bot commented May 4, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022
@github-actions github-actions bot closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants