Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support target authentication #33

Open
embano1 opened this issue Jun 25, 2021 · 9 comments
Open

Support target authentication #33

embano1 opened this issue Jun 25, 2021 · 9 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@embano1
Copy link

embano1 commented Jun 25, 2021

The send command currently assumes no authentication in the endpoint. kn event send is useful outside of direct Knative cluster access, e.g. to send Cloud Events to arbitrary webhooks or endpoints (services) in Kubernetes/Knative which enforce authentication, e.g. basic_auth.

What do you think about adding support for authentication schemes?

@cardil
Copy link
Contributor

cardil commented Jun 26, 2021

At first, I thought this is a good idea - a common case. But, then I recalled that this issue is similar to #31.

Seeing those two issues, I fear, a little, that after a while we might end up with having cURL number of options slipped to kn-event:

$ curl --help all | wc -l
241

I'm not sure is that a correct way to go. Maybe we could do better somehow...

Any ideas, @rhuss?

@embano1
Copy link
Author

embano1 commented Jun 27, 2021

Yeah, the API would certainly grow. But IMHO there's a couple of basic flags which should be supported, e.g. TLS, insecure and (basic) auth. Let's see what Roland says...

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2021
@cardil
Copy link
Contributor

cardil commented Sep 30, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2021
@cardil
Copy link
Contributor

cardil commented Jan 4, 2022

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 5, 2022
@cardil
Copy link
Contributor

cardil commented Apr 26, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2022
@rhuss
Copy link
Contributor

rhuss commented Jul 29, 2022

I'm +1 for adding security-related options as this is something that is not uncommon. At the moment I don't see that we will run into option bloat, so adding commonly used transport related options makes much sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

4 participants