VirtualService gets validation error - unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http

[nak3]

steps to reproduce

step-0. Deploy istio (I used istio-1.5 with mesh&galley)

step-1. Deploy any ksvc

step-2. Edit virtualservice

$ kubectl edit vs hello-example-ingress

step-3. Close without edit (by :q).

Actual result

Then, you get following error:

# virtualservices.networking.istio.io "hello-example-ingress" was not valid:
# * : Invalid value: "The edited file failed validation": [ValidationError(VirtualService.spec.http[0]): unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http, ValidationError(VirtualService.spec.http[1]): unknown field "websocketUpgrade" in io.istio.networking.v1beta1.VirtualService.spec.http]

Expected

The websocketUpgrade is already deprecated, so we should remove it.

https://github.com/knative/net-istio/blob/2833eeb85bda6c5ead740a4b871ce95c5d520a8e/vendor/istio.io/api/networking/v1alpha3/virtual_service.pb.go#L520-L522