Proposal: change the responce code in eventshub receiver for dropped events

[xinydev]

I am writing an e2e test for apiServerSource's retry feature, but the cloudevents.Client only retries when the HTTP response code is one of these.

I want to use eventshub to simulate a events lost scenario but the eventshub returns http.StatusConflict when dropping events. and the http.StatusConflict is not one of the codes which cloudevents.Client retries.

So I have a question. Is there any special reason to choose http.StatusConflict ?

Can we change it to 429(Too Many Requests) or 503(Service Unavailable) or 504(Gateway Timeout) for some tests scenario like retring?

Or is there any advices for this e2e test?

[xinydev]

@vaikas What do you think of this?

[vaikas]

Not totally sure if this would fit your use case, but for RabbitMQ Broker, I ended up using this:
https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/pkg/dispatcher/dispatcher.go#L80

With some more context here:
cloudevents/sdk-go#596

[xinydev]

Not totally sure if this would fit your use case, but for RabbitMQ Broker, I ended up using this:
https://github.com/knative-sandbox/eventing-rabbitmq/blob/main/pkg/dispatcher/dispatcher.go#L80

With some more context here:
cloudevents/sdk-go#596

Thanks! It is very helpful!

[vaikas]

Great to hear :) Ping me if you need some more help :)

[xinydev]

@vaikas Hi, what do you think we add a new env DropEventsResponseCode to config the status code returned when dropping events ?

I think in my scenario(knative/eventing#5457), it might not be good to modify the default strategy of cloudevent.Client
in pkg/adapter for the convenience of writing tests, because It may affect other components that use cloudevent.Client.

[pierDipi]

@xinydev makes sense to me, and it will be a lot useful for testing the behavior of some specific status codes with the upcoming changes here https://github.com/knative/specs/pull/24/files#diff-e71710278fc6ee3296a229b7448808ab0869b6ce9b3232a695b6f57fbc7ea6fdR95

[xinydev]

/assign