Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Tracing through KafkaChannel #563

Closed
Harwayne opened this issue Aug 29, 2019 · 3 comments
Closed

Tracing through KafkaChannel #563

Harwayne opened this issue Aug 29, 2019 · 3 comments
Labels
area/observability lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Harwayne
Copy link
Contributor

Harwayne commented Aug 29, 2019

Problem
A request made to the KafkaChannel should generate traces that link the request to the subscribers. It should either use an existing Trace if present, or create a new Trace if one isn't.

The trace from the Channel to any subscribers MUST be annotated with the subscription's name.

Persona:
System Integrator

Exit Criteria
Each of the following generate a trace that includes both the incoming request and the request to any subscribers. The trace from the Channel to any subscribers MUST be annotated with the subscription's name:

  • A request sent to an KafkaChannel without any trace information.
  • A request sent to an KafkaChannel with trace information in the HTTP headers (B3 format).
  • A request sent to an KafkaChannel with trace information in the Cloud Event's traceparent attribute, but not in the HTTP headers.

Note that this is very similar to knative/eventing#1757

@slinkydeveloper
Copy link
Contributor

I duplicated the issue here 😄 : #1139

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 11, 2020
@slinkydeveloper
Copy link
Contributor

This is solved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/observability lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants