Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra tracing span #1951

Closed
nachocano opened this issue Sep 23, 2019 · 1 comment · Fixed by #1972
Closed

Remove extra tracing span #1951

nachocano opened this issue Sep 23, 2019 · 1 comment · Fixed by #1972
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@nachocano
Copy link
Contributor

Describe the bug
It seems that we are creating an extra unreported span. #1944 improved on this a bit, but assumes that there is a *Span resident in memory, which works for InMemory, but probably not other channel implementations.
Need to use the traceparent event attribute for serialization into the CloudEvent itself.

Expected behavior
E2E tracing test checking for span should be uncommented.

Additional context
Comment from https://github.com/knative/eventing/pull/1933/files#r327255621

@nachocano nachocano added the kind/bug Categorizes issue or PR as related to a bug. label Sep 23, 2019
@nachocano
Copy link
Contributor Author

fyi @Harwayne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant