Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContainerSource CRD: metadata fields directly under "spec.template" #5353

Closed
antoineco opened this issue May 5, 2021 · 0 comments · Fixed by #5366
Closed

ContainerSource CRD: metadata fields directly under "spec.template" #5353

antoineco opened this issue May 5, 2021 · 0 comments · Fixed by #5366
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@antoineco
Copy link
Contributor

Describe the bug

In the ContainerSource CRD, all ObjectMeta fields are nested directly under spec.template instead of spec.template.metadata. This prevents users from setting those fields in their Pod template.

template:
description: 'Template describes the pods that will be created'
type: object
properties:
annotations:
description: 'Annotations is an unstructured key value map
stored with a resource that may be set by external tools
to store and retrieve arbitrary metadata. They are not
queryable and should be preserved when modifying objects.
More info: http://kubernetes.io/docs/user-guide/annotations'
type: object
x-kubernetes-preserve-unknown-fields: true

Expected behavior

To Reproduce

Knative release version

v0.18.0 onwards

Additional context

Caused by #3859

@antoineco antoineco added the kind/bug Categorizes issue or PR as related to a bug. label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant