Eventtype defaults to a "default" broker

[matzew]

Describe the bug

The EventType API defaults to a default broker, when not set:
https://github.com/knative/eventing/blob/main/pkg/apis/eventing/v1beta1/eventtype_defaults.go#L27

This is wrong, since it does assume there is an existing broker, called default. This is a poor assumption.

this does relate to #2750 and the tight coupling of EventType API and the brokers.

[matzew]

Related: #2750

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[pierDipi]

@matzew still relevant?

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[pierDipi]

/remove-lifecycle stale

[pierDipi]

/triage accepted

[pierDipi]

This's been worked in combination with #7264

[pierDipi]

For this issue, we need to remove the logic that defaults to broker named "default" in all EventType versions.

[pierDipi]

@Cali0707 is this done?

[Cali0707]

@pierDipi with v1beta2 being stored now, I think so, but I would like to check & maybe add a test to verify. Thanks for the ping here!

[matzew]

Just tested this:

k get eventtypes.eventing.knative.dev 
NAME                                  TYPE                             SOURCE                                SCHEMA   REFERENCE NAME   REFERENCE KIND   DESCRIPTION   READY   REASON
dev.knative.source.github.push-v1b1   dev.knative.source.github.push   https://github.com/knative/eventing            default          Broker                                 
dev.knative.source.github.push-v1b2   dev.knative.source.github.push   https://github.com/knative/eventing                                                                    

both brokers are having NO reference

[matzew]

@Cali0707 we have some API tests for that, I did tweak them a bit, as their naming was a bit confusing, given the old behavior, see here: #8030

[matzew]

Fix for this was here:

• feat: reconcile eventtype v1beta3 resources #8087
• EventType V1B3: Use proper jsonpath for additional column printer #8097 (little addon)
• fix: et v1beta3 does not have broker set by default #8079

[matzew]

/done