Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Event Filtering: Investigate dynamic array ordering optimization for event filters #7203

Closed
Cali0707 opened this issue Aug 24, 2023 · 1 comment · Fixed by #7205
Closed
Assignees
Labels
area/performance kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Problem
As seen in #7195 there is a large performance difference based on the ordering of filters.

Persona:
Which persona is this feature for?

Exit Criteria
A PR which dynamically re-orders the filters in the Any filter and shows the benchmark difference this change caused. If this strongly outperforms the base filter implementation, we can then extend this POC PR into the All filter and the top-level implicit all filter.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)

/area performance

@Cali0707
Copy link
Member Author

/triage accepted
/assign

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant