Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for the MQTT source #7966

Open
Cali0707 opened this issue Jun 5, 2024 · 2 comments
Open

Add e2e test for the MQTT source #7966

Cali0707 opened this issue Jun 5, 2024 · 2 comments
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jun 5, 2024

Problem
We recently introduced an MQTT source in #7919, but we do not currently have any tests for this. Ideally, it would be a separate job that can run in KinD so that it is straightforward to test and independent of other tests.

We need to:

  • Install an MQTT broker
  • Create a topic
  • Point the source image with a container source to a sink

Persona:
Which persona is this feature for?

Exit Criteria
An e2e test verifying the MQTT source works

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 2-3

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

Cali0707 commented Jun 5, 2024

cc @pierDipi @creydr not sure what you guys think about having a test that would require setting up MQTT, but also we have the MQTT container source now so I think it is worth testing...

@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Jun 6, 2024
@creydr
Copy link
Member

creydr commented Jun 7, 2024

+1 on adding an e2e test. But IMO we should then also think about moving this to a separate repo (as we have for the other "custom" sources - like eventing-github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants