-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webhook for EventPolicy
#7972
Comments
I did (perhaps wrongly) include this validation logic in this PR: #7995 |
Hey @dharmjit, |
Hey @dharmjit , let me know if you don't have sufficient bandwidth so that I can take this up while you are working on the reconciler part (which itself is a big part) |
@dharmjit are there anything I can help you with? If you're still working on this issue, please let me know within the next 24 hours. We understand that plans and priorities can change, and if you're no longer able to continue with this task, that's completely okay! In case I don't hear back from you in the next 24 hours, I'll reassign the issue to @rahulii to ensure our workflow continues smoothly. |
@Leo6Leo Apologies, I got caught up in some stuff. I will try to pick this up tomorrow and submit a PR. |
We need to add a webhook for EventPolicies, with at least the following validations for EventPolicies:
EventPolicy
must not be created, when theauthentication-oidc
feature flag isdisabled
EventPolicySpecTo
must only contain either aRef
or aSelector
. Not both at the same timePrerequisites:
EventPolicy
type #7971default-authorization-mode
feature flag #7974Additional context:
Additional hints for new contributors before starting with this issue:
Draft
status, the issue is subject to change and thus should not be started to be worked on/assign
). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.The text was updated successfully, but these errors were encountered: