-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Trigger Filters do not seem to perform any filtering #8018
Comments
Hi @cldfzn thanks for reporting this! I've tried to reproduce this with the following test case:
However, all of the tests passed when I ran this... Would you be able to provide the output of |
The broker that supports the new trigger filtering are: MTChannelBasedBroker and Kafka, RabbitMQ broker doesn't yet but we would welcome contributions cc @ikavgo |
Describe the bug
When I attempt to use a trigger with the new-trigger-filters feature enabled in the config-features configmap I do not see any filtering and a service attached to the trigger that is echoing the received events shows all events. If I add a
filter
block with thefilters
block thefilter
block takes precedence and filters the events properly. If I have read things correctly, it should not take precedence. I do get reconciliation errors if I put improper syntax in to thefilters
field though.Expected behavior
The filter should not forward all events to the service.
knative version: 1.14.0
The text was updated successfully, but these errors were encountered: