Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaC with GitHub not working with the .git suffixed form #1707

Closed
matejvasek opened this issue Apr 27, 2023 · 3 comments · Fixed by #1713
Closed

PaC with GitHub not working with the .git suffixed form #1707

matejvasek opened this issue Apr 27, 2023 · 3 comments · Fixed by #1713
Assignees
@matejvasek
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@matejvasek
Copy link
Contributor

matejvasek commented Apr 27, 2023 •
edited
Loading

The Pipelines as Code are not working when .git suffixed form (e.g. https://github.com/example/fn.git) is used.
Reason is that the .git part is confused as a part of the repo name.
@matejvasek
Copy link
Contributor Author

/label bug

@matejvasek matejvasek added the kind/bug Categorizes issue or PR as related to a bug. label Apr 27, 2023
@matejvasek matejvasek self-assigned this Apr 27, 2023
@matejvasek
Copy link
Contributor Author

I'll try to fix this.

@matejvasek
Copy link
Contributor Author

cc @zroubalik

@knative knative deleted a comment from knative-prow bot Apr 27, 2023
@matejvasek matejvasek changed the title PaC with GitHub not working with the .git suffixed form. PaC with GitHub not working with the .git suffixed form Apr 27, 2023
@matejvasek matejvasek mentioned this issue Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejvasek matejvasek

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: PaC not working with dot git suffixed URLs matejvasek/faas
1 participant
@matejvasek