Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-cluster build: Use unique PVC name used by a Pipeline #850

Closed
Tracked by #620
lance opened this issue Feb 22, 2022 · 7 comments
Closed
Tracked by #620

On-cluster build: Use unique PVC name used by a Pipeline #850

lance opened this issue Feb 22, 2022 · 7 comments
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. pipelines issues related to on-cluster builds via Tekton Pipelines

Comments

@lance
Copy link
Member

lance commented Feb 22, 2022

[UPDATE] by @zroubalik :
Reasoning behind this: if for some reasons the PVC created for a function is not ready/healthy and we would like to re-create the function (or one with the same name) we won't be able to do so, because the Pipeline will fail on the PVC creation.

We can just append a random number to the PVC name, but we need to be sure that we are using the correct PVC for the function -> we need to track the generated name somewhere locally or maybe use a k8s labels to find out whether the PV for this function already exists.

@lance lance mentioned this issue Feb 22, 2022
29 tasks
@lance lance moved this to Icebox (backlog and controversial items) in Func Roadmap Apr 6, 2022
@lance lance moved this from Icebox (backlog and controversial items) to In Design (typically large tasks with a feature track) in Func Roadmap Apr 6, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2022
@zroubalik
Copy link
Contributor

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2022
@lance lance added this to the 0.99.0 Release milestone Jul 28, 2022
@lance lance moved this from In Design to Icebox in Func Roadmap Sep 1, 2022
@lance lance modified the milestones: 0.99.0 Release, 1.0.0 Release Sep 14, 2022
@lance lance modified the milestones: 1.8.0 Release, 1.9.0 Release Oct 4, 2022
@lance lance moved this to ❄ Icebox in Functions WG Roadmap Oct 6, 2022
@lance lance modified the milestones: 1.9.0 Release, Release 1.10 Feb 14, 2023
@grafvonb
Copy link
Contributor

grafvonb commented Mar 27, 2023

@zroubalik what about other ideas like func deploy --remote --force or func deploy --remote --reset where it can mimic the behavior of func delete (or part of it)? In my opinion we should avoid "producing" too many temporary resources that need to be cleaned up later because they cause e.g. high storage consumption, e.g. the default size of a pvc on AWS with the EBS volume type is 1Gi and cannot be decreased even if our default size is 256Mi.

@lance lance modified the milestones: Release 1.10, Release 1.11 May 16, 2023
@lance lance removed the MVP label May 16, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2023
@lance
Copy link
Member Author

lance commented Aug 17, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2023
@lkingland lkingland removed this from the Release 1.11 milestone Aug 23, 2023
@lkingland lkingland added the pipelines issues related to on-cluster builds via Tekton Pipelines label Aug 23, 2023
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2024
@lkingland lkingland removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2024
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Icebox to In Design in Func Roadmap Jul 22, 2024
@github-project-automation github-project-automation bot moved this from ❄ Icebox to ✅ Done in Functions WG Roadmap Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. pipelines issues related to on-cluster builds via Tekton Pipelines
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants