Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the EnabledComponents field. #1478

Closed
mattmoor opened this issue Jul 10, 2020 · 3 comments · Fixed by #2162
Closed

Remove the EnabledComponents field. #1478

mattmoor opened this issue Jul 10, 2020 · 3 comments · Fixed by #2162
Labels
area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mattmoor
Copy link
Member

/area API
/kind cleanup

Deprecated here: #1476

We should remove it after stuff downstream is cleaned up.
@knative-prow-robot knative-prow-robot added area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 10, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Oct 9, 2020

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 9, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Oct 9, 2020

cc @vagababov

Looking for stuff to cleanup? :D

@dprotaso dprotaso mentioned this issue Jun 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drop deprecated enabledComponents field dprotaso/pkg
2 participants
@mattmoor @knative-prow-robot