Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RuntimeClass behind a feature flag #12921

Closed
dprotaso opened this issue May 9, 2022 · 4 comments
Closed

Support RuntimeClass behind a feature flag #12921

dprotaso opened this issue May 9, 2022 · 4 comments
Labels
area/API API objects and controllers triage/accepted Issues which should be fixed (post-triage)

Comments

@dprotaso
Copy link
Member

dprotaso commented May 9, 2022

The recommendation from @JRBANCEL is to use Feature Flags to support RuntimeClass.

Here is an example that adds support for node selector and affinity: #8645

Can this issue be reopened?

Originally posted by @fvoznika in #5306 (comment)
@dprotaso
Copy link
Member Author

dprotaso commented May 9, 2022

/triage accepted
/milestone Icebox

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label May 9, 2022
@dprotaso
Copy link
Member Author

dprotaso commented May 9, 2022

/area API

@knative-prow knative-prow bot added the area/API API objects and controllers label May 9, 2022
@dprotaso dprotaso added this to the Icebox milestone May 9, 2022
@skonto
Copy link
Contributor

skonto commented May 11, 2022 •
edited
Loading

@dprotaso I think this is supported already:

serving/config/core/configmaps/features.yaml

Line 89 in f778a37

kubernetes.podspec-runtimeclassname: "disabled"
?

@dprotaso
Copy link
Member Author

looks whoops - you're right

@dprotaso dprotaso removed this from the Icebox milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API API objects and controllers triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dprotaso @skonto